Code indexing in gitaly is broken and leads to code not being visible to the user. We work on the issue with highest priority.

Skip to content

feat(slot): add 'verify_sender' argument to SafeSlot for sender verification

wakonig_k requested to merge feature/safe_slot_sender_verification into pre_release_v2

Description

This MR adds an additional kwarg to SafeSlot to restrict the underlying method to calls to signal events from alive and not yet destroyed QObjects. It is opt-in (i.e. default is False) but should be used for slots where the subscription changes frequently, e.g. on every scan.

Related Issues

closes #546

Type of Change

  • add 'verify_sender' kwarg to SafeSlot

Additional Comments

This MR doesn't apply the new kwarg to any slot yet but there are tests ensuring its functionality.

Definition of Done

  • Documentation is up-to-date.
Edited by wakonig_k

Merge request reports